The casting includes royalty playing the officer class roles and some talented supporting actors playing the cannon fodder. However, the main strength of the film is its excellent production values in both peace and war.
Ron Moody anchors the performance side of things and is helped by a cast of excellent character actors but the strength is in the songs some of which will continue to be timeless.
I think the comedy misfired but it does have supporters who believe the comedy to have been misunderstood. Even as a misfire it does have some reasonable segments though.